Skip to content

Use JsonPointer syntax#348

Open
usku01 wants to merge 12 commits into
mainfrom
feature/#344-use-json-pointer-syntax
Open

Use JsonPointer syntax#348
usku01 wants to merge 12 commits into
mainfrom
feature/#344-use-json-pointer-syntax

Conversation

@usku01

@usku01 usku01 commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@usku01 usku01 requested a review from a team June 19, 2026 08:40
@jpraet

jpraet commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

JsonPointer syntax only needs to be used for InEnum.BODY.
A query, path or header param with name "foo.bar" should be accepted.

@usku01

usku01 commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator Author

JsonPointer syntax only needs to be used for InEnum.BODY. A query, path or header param with name "foo.bar" should be accepted.

What if we have a query parameter which would be a list, shouldn't we add the index in the name? And what I mean by that is of the query param is named 'parameter.id', if we have an issue with the second member of the list, then the name in the issue should be 'parameter.id/1'?

@usku01

usku01 commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator Author

JsonPointer syntax only needs to be used for InEnum.BODY. A query, path or header param with name "foo.bar" should be accepted.

What if we have a query parameter which would be a list, shouldn't we add the index in the name? And what I mean by that is of the query param is named 'parameter.id', if we have an issue with the second member of the list, then the name in the issue should be 'parameter.id/1'?

I have applied changes to the implementation to allow "." in name

@jpraet

jpraet commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

JsonPointer syntax only needs to be used for InEnum.BODY. A query, path or header param with name "foo.bar" should be accepted.

What if we have a query parameter which would be a list, shouldn't we add the index in the name? And what I mean by that is of the query param is named 'parameter.id', if we have an issue with the second member of the list, then the name in the issue should be 'parameter.id/1'?

I think it's fine to keep using parameter.id[1] there.
JSON Pointer is specifically for pointing to a specific value within a JSON object.

@usku01 usku01 requested a review from jpraet June 26, 2026 09:15
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants